HanumathRao commented on PR #2935: URL: https://github.com/apache/calcite/pull/2935#issuecomment-1279557853
Thanks @zabetak for the review. I have addressed all the comments except the following. _It is better to put the row count check in the matches method. When the condition is not satisfied the rule can be eliminated much earlier._ I am using the call context to get the RelMetadataQuery, I think this is not fully formed during the matching of the rule. I thought about using the MetadataQuery singleton INSTANCE, but it can get complex during the matching. Please let me know if you have an easier way in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
