julianhyde commented on code in PR #183:
URL: https://github.com/apache/calcite-avatica/pull/183#discussion_r1002773357
##########
core/src/main/java/org/apache/calcite/avatica/AvaticaUtils.java:
##########
@@ -211,6 +211,7 @@ public static <T> T instantiatePlugin(Class<T> pluginClass,
String className) {
String right = null;
String left = null;
+ Object value = null;
Review Comment:
In fa3244a99 I have improved the javadoc for the 'Class#FOO' case.
I don't think we should allow `INSTANCE` to be a `ThreadLocal` because in
the singleton pattern INSTANCE should have the same type as its enclosing class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
