richardantal commented on code in PR #184:
URL: https://github.com/apache/calcite-avatica/pull/184#discussion_r1004621717
##########
server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java:
##########
@@ -850,6 +875,9 @@ protected SslContextFactory.Server buildSSLContextFactory()
{
sslFactory.setKeyStorePassword(keystorePassword);
sslFactory.setTrustStorePath(truststore.getAbsolutePath());
sslFactory.setTrustStorePassword(truststorePassword);
+ if (keystoreType != null &&
!keystoreType.equals(DEFAULT_KEYSTORE_TYPE)) {
+ sslFactory.setKeyStoreType(keystoreType);
Review Comment:
Jetty supports other key-store formats as well, for example BCFKS key
format. BCFKS is FIPS compatible but the default JKS is not.
This way we will be able configure the key-store format from
phoenix-queryserver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
