libenchao commented on code in PR #2952:
URL: https://github.com/apache/calcite/pull/2952#discussion_r1008864624
##########
core/src/main/java/org/apache/calcite/sql/SqlWithItem.java:
##########
@@ -97,7 +97,7 @@ private static class SqlWithItemOperator extends
SqlSpecialOperator {
withItem.columnList.unparse(writer, getLeftPrec(), getRightPrec());
}
writer.keyword("AS");
- withItem.query.unparse(writer, 10, 10);
+ withItem.query.unparse(writer, 100, 100);
Review Comment:
To be honest, I don't like current approach (deferring adding parentheses in
`SqlCall`). Since we should always add parentheses after `AS`, how about doing
this like:
```java
final SqlWriter.Frame frame = writer.startList("(", ")");
withItem.query.unparse(writer, 0, 0);
writer.endList(frame);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
