libenchao commented on code in PR #2929:
URL: https://github.com/apache/calcite/pull/2929#discussion_r1022252807
##########
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##########
@@ -1790,10 +1790,11 @@ private RexNode createCaseExpression(
@Override public RexNode visitLiteral(RexLiteral literal) {
// Use nullIndicator to decide whether to project null.
- // Do nothing if the literal is null.
+ // Do nothing if the literal is null or symbol.
if (!RexUtil.isNull(literal)
Review Comment:
The whole story lies in `RelDecorrelator#RemoveCorrelationRexShuttle`. When
`projectPulledAboveLeftCorrelator && (nullIndicator != null)` is `true`,
currently it will add a case for all expressions.
Maybe your feeling is right, I haven't thought it thorough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
