julianhyde commented on code in PR #2989: URL: https://github.com/apache/calcite/pull/2989#discussion_r1037570371
########## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperatorTableFactory.java: ########## @@ -16,6 +16,15 @@ */ package org.apache.calcite.sql.fun; +import org.apache.calcite.config.CalciteConnectionConfigImpl; +import org.apache.calcite.jdbc.CalciteSchema; +import org.apache.calcite.jdbc.JavaTypeFactoryImpl; +import org.apache.calcite.model.ModelHandler; +import org.apache.calcite.prepare.CalciteCatalogReader; +import org.apache.calcite.runtime.SpatialTypeFunctions; +import org.apache.calcite.schema.Function; +import org.apache.calcite.schema.SchemaPlus; Review Comment: The large number of new imports is an indication that the code to define the aggregate functions should be somewhere else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
