freastro commented on code in PR #2995:
URL: https://github.com/apache/calcite/pull/2995#discussion_r1040280334
##########
testkit/src/main/java/org/apache/calcite/test/QuidemTest.java:
##########
@@ -293,6 +293,7 @@ public Connection connect(String name) throws Exception {
.connect();
case "catchall":
return CalciteAssert.that()
+ .with(CalciteConnectionProperty.TIME_ZONE, "UTC")
Review Comment:
I made a change in DateTimeUtils (see CALCITE-2989) that ensures the date
and time accessors in AbstractCursor have the same behavior for their
getString() methods, and that required a change here to fix CoreQuidemTest. The
default time zone is the local time zone, but CatchallSchema is creating
`java.sql.Date`, `java.sql.Time`, and `java.sql.Timestamp` values using the UTC
time zone. I verified the tests are passing in multiple timezones: UTC,
America/Los_Angeles, America/New_York, Pacific/Chatham, Pacific/Samoa, and
Pacific/Tongatapu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
