libenchao commented on code in PR #2977:
URL: https://github.com/apache/calcite/pull/2977#discussion_r1045031294
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java:
##########
@@ -693,7 +696,7 @@ private static Pair<Expression, Expression>
getPartitionIterator(
}
Expression multiMap_ =
builder.append(
- "multiMap", Expressions.new_(SortedMultiMap.class));
+ "multiMap", Expressions.new_(SortedMultiMap.class), false);
Review Comment:
> Although I started to think, that I should revert changes for "multiMap"
and create separate ticket for improving optimizer.
I saw that CALCITE-5426 has been created. And reverting changes for
"multiMap" would make this PR more clean and self-contained, it would look good
to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
