julianhyde commented on code in PR #3000:
URL: https://github.com/apache/calcite/pull/3000#discussion_r1046138609
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -7534,6 +7534,10 @@ private static void
checkArrayConcatAggFuncFails(SqlOperatorFixture t) {
f.checkScalar("timestampdiff(\"month4\", date '2016-02-24', "
+ "date '2016-02-23')",
"0", "INTEGER NOT NULL");
+
f.withLibrary(SqlLibrary.BIG_QUERY).setFor(SqlLibraryOperators.TIMESTAMP_DIFF)
+ .checkScalar("timestamp_diff(timestamp '2008-12-25 15:30:00', "
+ + "timestamp '2008-12-25 16:30:00', \"minute15\")",
+ "4", "INTEGER NOT NULL");
Review Comment:
My mistake. This test is fine here.
I’d break the line before “.setFor”. Long lines are difficult to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
