[calcite] branch main updated: [CALCITE-5439] Validation of Pivot fails after creating a deep copy of SqlNode

[libenchao]

This is an automated email from the ASF dual-hosted git repository.

libenchao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git


The following commit(s) were added to refs/heads/main by this push:
     new 81efd2adf3 [CALCITE-5439] Validation of Pivot fails after creating a 
deep copy of SqlNode
81efd2adf3 is described below

commit 81efd2adf38af629cf2bab0cba081e0b47ba4a1f
Author: Volodymyr Vysotskyi <vvo...@gmail.com>
AuthorDate: Sat Dec 17 11:50:12 2022 +0200

    [CALCITE-5439] Validation of Pivot fails after creating a deep copy of 
SqlNode
---
 .../main/java/org/apache/calcite/sql/SqlPivot.java | 13 +++++++++++++
 .../apache/calcite/sql/parser/SqlParserTest.java   | 22 ++++++++++++++++++++++
 2 files changed, 35 insertions(+)

diff --git a/core/src/main/java/org/apache/calcite/sql/SqlPivot.java 
b/core/src/main/java/org/apache/calcite/sql/SqlPivot.java
index cb5fa4ee74..6a082b1433 100644
--- a/core/src/main/java/org/apache/calcite/sql/SqlPivot.java
+++ b/core/src/main/java/org/apache/calcite/sql/SqlPivot.java
@@ -35,6 +35,8 @@ import java.util.Set;
 import java.util.function.BiConsumer;
 import java.util.stream.Collectors;
 
+import static java.util.Objects.requireNonNull;
+
 /**
  * Parse tree node that represents a PIVOT applied to a table reference
  * (or sub-query).
@@ -195,5 +197,16 @@ public class SqlPivot extends SqlCall {
     Operator(SqlKind kind) {
       super(kind.name(), kind);
     }
+
+    @Override public SqlCall createCall(
+        @Nullable SqlLiteral functionQualifier,
+        SqlParserPos pos,
+        @Nullable SqlNode... operands) {
+      assert operands.length == 4;
+      return new SqlPivot(pos, requireNonNull(operands[0], "query"),
+          requireNonNull((SqlNodeList) operands[1], "aggList"),
+          requireNonNull((SqlNodeList) operands[2], "axisList"),
+          requireNonNull((SqlNodeList) operands[3], "inList"));
+    }
   }
 }
diff --git 
a/testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java 
b/testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java
index eab5658b34..223a2b0bd7 100644
--- a/testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java
+++ b/testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java
@@ -9044,6 +9044,28 @@ public class SqlParserTest {
     sql(sql).ok(expected);
   }
 
+  @Test void testPivotThroughShuttle() {
+    final String sql = ""
+        + "SELECT *\n"
+        + "FROM (SELECT job, deptno FROM \"EMP\")\n"
+        + "PIVOT (COUNT(*) AS \"COUNT\" FOR deptno IN (10, 50, 20))";
+    final String expected = ""
+        + "SELECT *\n"
+        + "FROM (SELECT `JOB`, `DEPTNO`\n"
+        + "FROM `EMP`) PIVOT (COUNT(*) AS `COUNT` FOR `DEPTNO` IN (10, 50, 
20))";
+    final SqlNode sqlNode = sql(sql).node();
+
+    final SqlNode shuttled = sqlNode.accept(new SqlShuttle() {
+      @Override public @Nullable SqlNode visit(final SqlCall call) {
+        // Handler always creates a new copy of 'call'
+        CallCopyingArgHandler argHandler = new CallCopyingArgHandler(call, 
true);
+        call.getOperator().acceptCall(this, call, false, argHandler);
+        return argHandler.result();
+      }
+    });
+    assertThat(toLinux(shuttled.toString()), is(expected));
+  }
+
   @Test void testMatchRecognize1() {
     final String sql = "select *\n"
         + "  from t match_recognize\n"