julianhyde commented on code in PR #205:
URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081983370
##########
core/src/main/java/org/apache/calcite/avatica/AvaticaResultSet.java:
##########
@@ -77,7 +78,9 @@ public AvaticaResultSet(AvaticaStatement statement,
ResultSetMetaData resultSetMetaData,
TimeZone timeZone,
Meta.Frame firstFrame) throws SQLException {
- super(timeZone);
+ // Initialize the parent ArrayFactory with the UTC time zone because
otherwise an array of
Review Comment:
> So, there's certainly an existing bug in the implementation of
Array.getResultSet() that only manifests
> when the array contains timestamps and when the connection default time
zone is not GMT, and this
> was not covered by tests
I don't know of any such bugs. But your changes do seem to make things worse
- by ensuring that the nested `AvaticaResultSet` set does not get the right
`timeZone`.
If there's a bug, log it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
