tjbanghart commented on code in PR #3034:
URL: https://github.com/apache/calcite/pull/3034#discussion_r1092479733
##########
core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java:
##########
@@ -271,6 +272,50 @@ private static TimeUnit validate(TimeUnit timeUnit) {
}
}
+ /** {@inheritDoc}
+ *
+ * <p>BigQuery format element reference:
+ * <a
href="https://cloud.google.com/bigquery/docs/reference/standard-sql/format-elements";>
+ * BigQuery Standard SQL Format Elements</a>.
+ */
+ @Override public String getFormatElement(FormatElementEnum fmtElement) {
Review Comment:
As a followup to this PR, we can define non-standard element maps per
dialect. Then, when we unparse a formatting function we would use the map to
find the appropriate element string for the "standard" element. The map would
be bi-directional as suggested so that it can be used as both the parse map for
functions and for converting elements from one dialect to another.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
