This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git
commit 7abc5a4c22488d3c6a605f1da249914424f23b68 Author: Julian Hyde <[email protected]> AuthorDate: Fri Feb 10 00:23:46 2023 -0800 Add test for [CALCITE-5524] JDBC adapter generates LIMIT, OFFSET in wrong order for Presto dialect The Presto dialect already has the correct behavior: generate OFFSET before LIMIT. --- .../apache/calcite/rel/rel2sql/RelToSqlConverterTest.java | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java b/core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java index 8aa886ceee..ca715e2033 100644 --- a/core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java +++ b/core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java @@ -3920,12 +3920,20 @@ class RelToSqlConverterTest { @Test void testFetchOffset() { String query = "SELECT * FROM \"employee\" LIMIT 1 OFFSET 1"; - String expectedMssql = "SELECT *\nFROM [foodmart].[employee]\nOFFSET 1 ROWS\n" + String expectedMssql = "SELECT *\n" + + "FROM [foodmart].[employee]\n" + + "OFFSET 1 ROWS\n" + "FETCH NEXT 1 ROWS ONLY"; - String expectedSybase = "SELECT TOP (1) START AT 1 *\nFROM foodmart.employee"; + String expectedSybase = "SELECT TOP (1) START AT 1 *\n" + + "FROM foodmart.employee"; + final String expectedPresto = "SELECT *\n" + + "FROM \"foodmart\".\"employee\"\n" + + "OFFSET 1\n" + + "LIMIT 1"; sql(query) .withMssql().ok(expectedMssql) - .withSybase().ok(expectedSybase); + .withSybase().ok(expectedSybase) + .withPresto().ok(expectedPresto); } @Test void testFloorMssqlMonth() {
