julianhyde commented on code in PR #207:
URL: https://github.com/apache/calcite-avatica/pull/207#discussion_r1106320315
##########
core/src/test/java/org/apache/calcite/avatica/AvaticaResultSetConversionsTest.java:
##########
@@ -215,15 +270,18 @@ public TestMetaImpl(AvaticaConnection connection) {
List<Object> row = Collections.<Object>singletonList(
new Object[] {
true, (byte) 1, (short) 2, 3, 4L, 5.0f, 6.0d, "testvalue",
- new Date(1476130718123L), new Time(1476130718123L),
- new Timestamp(1476130718123L),
+ new Date(DST_INSTANT), new Time(DST_INSTANT),
Review Comment:
When I merge to main, I might split out a 'refactor' commit that does not
add or change tests but just moves literals into constant fields. That will
reduce confusion for future readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
