libenchao commented on PR #3073: URL: https://github.com/apache/calcite/pull/3073#issuecomment-1435468507
@zoudan Thanks for the PR! The changes looks good to me. I have two minor comments: 1. We usually do to not use 'Fix xxx' as the commit message, instead, we prefer to use a sentence which describes the symptom of the issue 2. The CI fails now, it seems unrelated with current change. Just a reminder, you can use `git commit --allow-empty -m "Insert you message"` to add a empty commit to trigger the CI again. You can find these instructions in https://calcite.apache.org/develop/#contributing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
