libenchao commented on code in PR #3075:
URL: https://github.com/apache/calcite/pull/3075#discussion_r1110950764
##########
core/src/main/java/org/apache/calcite/rel/RelDistributions.java:
##########
@@ -38,19 +38,14 @@
public class RelDistributions {
public static final ImmutableIntList EMPTY = ImmutableIntList.of();
- /** The singleton singleton distribution. */
Review Comment:
I guess this is not a 'typo'. You can see other comments below, the first
'singleton' means the design pattern is 'singleton', and the second 'singleton'
means the 'singleton distribution'.
##########
core/src/main/java/org/apache/calcite/rel/RelDistributions.java:
##########
@@ -38,19 +38,14 @@
public class RelDistributions {
public static final ImmutableIntList EMPTY = ImmutableIntList.of();
- /** The singleton singleton distribution. */
+ /** The singleton distribution. */
public static final RelDistribution SINGLETON =
new RelDistributionImpl(RelDistribution.Type.SINGLETON, EMPTY);
/** The singleton random distribution. */
public static final RelDistribution RANDOM_DISTRIBUTED =
new RelDistributionImpl(RelDistribution.Type.RANDOM_DISTRIBUTED, EMPTY);
- /** The singleton round-robin distribution. */
- public static final RelDistribution ROUND_ROBIN_DISTRIBUTED =
Review Comment:
Why are you proposing to remove this? (Notice that, Calcite is a framework
used by many third-party projects, hence even some code has no usage in Calcite
itself, we cannot remove them safely)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
