libenchao commented on code in PR #3057:
URL: https://github.com/apache/calcite/pull/3057#discussion_r1111843082


##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -1756,6 +1757,35 @@ private SqlDialect nonOrdinalDialect() {
         + "FROM \"foodmart\".\"employee\"");
   }
 
+  /** Test case for
+   * <a 
href="https://issues.apache.org/jira/browse/CALCITE-5510";>[CALCITE-5510]
+   * RelToSqlConverter don't support sort by ordinal when sort by column is an 
expression</a>.
+   */
+  @Test void testOrderByOrdinalWithExpression() {
+    String query = "select \"product_id\", count(*) as \"c\"\n"

Review Comment:
   `final`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to