tanclary commented on code in PR #3079:
URL: https://github.com/apache/calcite/pull/3079#discussion_r1116728805
##########
core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java:
##########
@@ -1974,27 +1982,42 @@ private static class TimestampDiffConvertlet implements
SqlRexConvertlet {
SqlIntervalQualifier qualifier;
final RexNode op1;
final RexNode op2;
- if (call.operand(0).getKind() == SqlKind.INTERVAL_QUALIFIER) {
- qualifier = call.operand(0);
- op1 = cx.convertExpression(call.operand(1));
- op2 = cx.convertExpression(call.operand(2));
- } else {
+ final boolean isBigQuery = !(call.operand(0).getKind() ==
SqlKind.INTERVAL_QUALIFIER);
Review Comment:
I moved and modified my comments a bit, feel free to let me know if you have
other suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
