zoudan commented on code in PR #3005:
URL: https://github.com/apache/calcite/pull/3005#discussion_r1118234434


##########
core/src/test/java/org/apache/calcite/test/TypeCoercionConverterTest.java:
##########
@@ -173,6 +173,20 @@ public static void checkActualAndReferenceFiles() {
     sql(sql).ok();
   }
 
+  @Test void testInsertValuesDifferentColumnTypes() {

Review Comment:
   `testInsertValuesDifferentColumnTypes` may not be a perfect name here, how 
about `testInsertValuesWithConvertibleTypes` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to