olivrlee commented on code in PR #3084:
URL: https://github.com/apache/calcite/pull/3084#discussion_r1120803687
##########
core/src/main/java/org/apache/calcite/jdbc/Driver.java:
##########
@@ -64,6 +64,15 @@ public Driver() {
this.prepareFactory = createPrepareFactory();
}
+ private Driver(Function0<CalcitePrepare> prepareFactory) {
Review Comment:
The way that its designed seems to imply some conflicting restraints
- we need `createPrepareFactory()` to be override-able (use cases in
JdbcTest.java), thus has to stay an instance method
- we want `prepareFactory` to be `final`
- all constructors except 1 have to call 1 constructor
Is there a way to satisfy all 3 without conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
