julianhyde commented on PR #3086: URL: https://github.com/apache/calcite/pull/3086#issuecomment-1460871239
Looks good. In a couple of places you use bigQuery terminology and refer to datetime types; can you change these to use Calcite terminology. E.g. `datetimeExpression` should be `timestamp`, and `date_time_part` should be `timeUnit`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
