libenchao commented on code in PR #3092:
URL: https://github.com/apache/calcite/pull/3092#discussion_r1131819994
##########
testkit/src/main/java/org/apache/calcite/test/catalog/MockCatalogReaderSimple.java:
##########
@@ -291,13 +297,10 @@ protected MockCatalogReaderSimple(RelDataTypeFactory
typeFactory,
registerTable(suppliersTable);
// Register "EMP_20" and "EMPNULLABLES_20 views.
- // Same columns as "EMP" amd "EMPNULLABLES",
- // but "DEPTNO" not visible and set to 20 by default
- // and "SAL" is visible but must be greater than 1000,
- // which is the equivalent of:
+ // Same columns as "EMP" amd "EMPNULLABLES", but "DEPTNO" not visible and
set to 20 by default
+ // and "SAL" is visible but must be greater than 1000, which is the
equivalent of:
Review Comment:
I see, then we'd better split this method into smaller ones in a separate
issue, and I'm ok for this workaround in this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
