olivrlee commented on code in PR #3093:
URL: https://github.com/apache/calcite/pull/3093#discussion_r1132905701
##########
core/src/main/java/org/apache/calcite/rex/RexExecutable.java:
##########
@@ -102,6 +102,38 @@ public void reduce(RexBuilder rexBuilder, List<RexNode>
constExps,
Hook.EXPRESSION_REDUCER.run(Pair.of(code, values));
}
+ /**
+ * Same as {@link #reduce(RexBuilder, List, List)} but with a flag to throw
on failure.
+ * <p>Catch the exception to return null for SAFE_ functions.</p>
Review Comment:
This was because you had a comment saying public methods shouldnt just be
changed, but a new one should be written and the old deprecated -- maybe that
doesn't apply here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
