julianhyde commented on code in PR #3093:
URL: https://github.com/apache/calcite/pull/3093#discussion_r1133140735
##########
core/src/main/java/org/apache/calcite/rex/RexExecutable.java:
##########
@@ -102,6 +102,38 @@ public void reduce(RexBuilder rexBuilder, List<RexNode>
constExps,
Hook.EXPRESSION_REDUCER.run(Pair.of(code, values));
}
+ /**
+ * Same as {@link #reduce(RexBuilder, List, List)} but with a flag to throw
on failure.
+ * <p>Catch the exception to return null for SAFE_ functions.</p>
Review Comment:
You can usually move the method body into the new method (with the extra
parameter) and have the old (deprecated) method call the new method.
If the old method is deprecated you should change all calls to use the new
method, and remove its javadoc. Thus the new method's javadoc wouldn't be 'Same
as (old method)'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
