snuyanzin commented on code in PR #3105: URL: https://github.com/apache/calcite/pull/3105#discussion_r1133203768
########## core/src/main/java/org/apache/calcite/sql/SqlMapTypeNameSpec.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.sql; + +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.sql.parser.SqlParserPos; +import org.apache.calcite.sql.type.SqlTypeName; +import org.apache.calcite.sql.validate.SqlValidator; +import org.apache.calcite.util.Litmus; + +/** + * Parse SQL MAP type, i.e. MAP<INT NOT NULL, TIMESTAMP NULL>, the key and value can specify a + * suffix to indicate if the type is nullable, default is nullable. + * + * <p>MAP type does not belong to standard SQL. + */ +public class SqlMapTypeNameSpec extends SqlTypeNameSpec { + + private final SqlDataTypeSpec keyType; + private final SqlDataTypeSpec valType; + + /** + * Creates a {@code SqlMapTypeNameSpec}. + * + * @param keyType key type + * @param valType value type + * @param pos the parser position + */ + public SqlMapTypeNameSpec(SqlDataTypeSpec keyType, SqlDataTypeSpec valType, SqlParserPos pos) { + super(new SqlIdentifier(SqlTypeName.MAP.getName(), pos), pos); + this.keyType = keyType; + this.valType = valType; + } + + public SqlDataTypeSpec getKeyType() { + return keyType; + } + + public SqlDataTypeSpec getValType() { + return valType; + } + + @Override public RelDataType deriveType(SqlValidator validator) { + return validator + .getTypeFactory() + .createMapType(keyType.deriveType(validator), valType.deriveType(validator)); + } + + @Override public void unparse(SqlWriter writer, int leftPrec, int rightPrec) { + writer.keyword("MAP"); + SqlWriter.Frame frame = writer.startList(SqlWriter.FrameTypeEnum.FUN_CALL, "<", ">"); + writer.sep(","); // configures the writer + keyType.unparse(writer, leftPrec, rightPrec); + // Default is nullable. + if (keyType.getNullable() != null && !keyType.getNullable()) { Review Comment: I guess checkerframework thinks the value could be changed between two invocations... Probably it's better to extract `keyType.getNullable()` in a separate var to make checkerframework happy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
