zoudan commented on code in PR #3134:
URL: https://github.com/apache/calcite/pull/3134#discussion_r1155458273
##########
core/src/test/java/org/apache/calcite/test/SqlFunctionsTest.java:
##########
Review Comment:
Shall we add some tests in SqlOperatorTest?
##########
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##########
@@ -165,10 +173,17 @@ public enum FormatElementEnum implements FormatElement {
return String.format(Locale.ROOT, "%02d", calendar.get(Calendar.SECOND));
}
},
+ MS("The millisecond as a decimal number (000-999)") {
+ @Override public String format(Date date) {
+ final Calendar calendar = Work.get().calendar;
+ calendar.setTime(date);
+ return String.format(Locale.ROOT, "%03d",
calendar.get(Calendar.MILLISECOND));
+ }
+ },
TZR("The time zone name") {
@Override public String format(Date date) {
// TODO: how to support timezones?
- throw new UnsupportedOperationException();
+ return "";
Review Comment:
why we return empty string for this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
