MasseGuillaume commented on code in PR #3141:
URL: https://github.com/apache/calcite/pull/3141#discussion_r1164532522


##########
core/src/main/codegen/templates/Parser.jj:
##########
@@ -4708,14 +4708,40 @@ SqlNode ArrayConstructor() :
 {
     <ARRAY> { s = span(); }
     (
-        LOOKAHEAD(1)
-        <LPAREN>
-        // by sub query "MULTISET(SELECT * FROM T)"
-        e = OrderedQueryOrExpr(ExprContext.ACCEPT_QUERY)
-        <RPAREN>

Review Comment:
   Ok, I will remove the conformance. I'm not sure I understand the 
implementation, do you want to always parse a function call? Then in the 
`SqlValidator`, when the array function is loaded (via the Spark library) 
validate that all the arguments are non-query expressions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to