adamkennedy opened a new pull request, #3151:
URL: https://github.com/apache/calcite/pull/3151

   This PR corrects a row count call to use the RelMetadataQuery instead of 
going directly to rel.estimateRowCount.
   
   Using rel.estimateRowCount directly will behave incorrectly when using a 
cardinality estimator that is implemented entirely in a 
MetadataHandler<RowCount> class, as it will evade the metadata handler's 
implementation of getRowCount and fall through to the underlying default method 
for Values.
   
   This corrects the problem by using mq.getRowCount instead of 
rel.estimateRowCount. In the default case this results in the same value but in 
the custom cardinality model case the expected handler is called.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to