zinking commented on code in PR #3042:
URL: https://github.com/apache/calcite/pull/3042#discussion_r1167387469
##########
core/src/main/java/org/apache/calcite/rel/logical/LogicalFilter.java:
##########
@@ -47,7 +47,7 @@
* not targeted at any particular engine or calling convention.
*/
public final class LogicalFilter extends Filter {
- private final ImmutableSet<CorrelationId> variablesSet;
+ private final Set<CorrelationId> variablesSet;
Review Comment:
is it possible to keep the immutableSet here? generally Immutable should be
preferred.
could you complete the title and justify the cases where Immutable
structures are changed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
