ILuffZhe commented on code in PR #3173:
URL: https://github.com/apache/calcite/pull/3173#discussion_r1182155697
##########
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java:
##########
@@ -443,6 +443,7 @@ public enum BuiltInMethod {
String.class, boolean.class),
REPLACE(SqlFunctions.class, "replace", String.class, String.class,
String.class),
+ TRANSLATE(SqlFunctions.class, "translateWithCharset", String.class,
String.class),
Review Comment:
> Nearly there. A few doc changes will be helpful, because these functions
are confusingly similar to other TRANSLATE and CONVERT functions
@julianhyde Thanks for the review. I've updated the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
