julianhyde commented on code in PR #3168:
URL: https://github.com/apache/calcite/pull/3168#discussion_r1188031401
##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -10501,7 +10508,8 @@ private void checkCustomColumnResolving(String table) {
final String sql4 = "insert into EMP_MODIFIABLEVIEW2(\"extra\" INTEGER)"
+ " (empno, ename, job, \"extra\")\n"
+ "values (1, 'Arthur', 'clown', true)";
- s.withSql(sql4).ok();
+
s.withConformance(SqlConformanceEnum.BIG_QUERY).withTypeCoercion(true).withSql(sql4).ok();
Review Comment:
you've checked that it's ok on BigQuery... but if so, why only BigQuery?
should it fail on other conformances?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
