chunweilei commented on code in PR #3189:
URL: https://github.com/apache/calcite/pull/3189#discussion_r1188262158
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlCastFunction.java:
##########
@@ -122,8 +128,50 @@ static SqlReturnTypeInference returnTypeInference(boolean
safe) {
/** Derives the type of "CAST(expression AS targetType)". */
public static RelDataType deriveType(RelDataTypeFactory typeFactory,
RelDataType expressionType, RelDataType targetType, boolean safe) {
- return typeFactory.createTypeWithNullability(targetType,
- expressionType.isNullable() || safe);
+ return createTypeWithNullabilityFromExpr(typeFactory, expressionType,
targetType, safe);
+ }
+
+ private static RelDataType
createTypeWithNullabilityFromExpr(RelDataTypeFactory typeFactory,
+ RelDataType expressionType, RelDataType targetType, boolean safe) {
+ boolean isNullable = expressionType.isNullable() || safe;
+
+ if (isCollection(expressionType)) {
+ RelDataType expressionElementType = expressionType.getComponentType();
+ RelDataType targetElementType = targetType.getComponentType();
+ RelDataType newElementType =
+ createTypeWithNullabilityFromExpr(typeFactory,
expressionElementType, targetElementType, false);
+ if (isArray(expressionType)) {
+ return SqlTypeUtil.createArrayType(typeFactory, newElementType,
isNullable);
+ } else {
+ return SqlTypeUtil.createMultisetType(typeFactory, newElementType,
isNullable);
Review Comment:
Maybe we can use `isArray(expressionType) ? xxx: yyy` to be more concise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
