JiajunBernoulli commented on code in PR #3215:
URL: https://github.com/apache/calcite/pull/3215#discussion_r1199707510
##########
babel/src/main/codegen/config.fmpp:
##########
@@ -578,9 +578,14 @@ data: {
]
# Custom identifier token.
- # Example: "< IDENTIFIER: (<LETTER>|<DIGIT>)+ >".
- customIdentifierToken: "< IDENTIFIER: (<LETTER>|<DIGIT>)+ >"
-
+ #
+ # PostgreSQL allows letters with diacritical marks and non-Latin letters
+ # in the beginning of identifier and additionally dollar sign in the rest
of identifier.
+ # See
https://github.com/postgres/postgres/blob/master/src/backend/parser/scan.l
+ #
+ # MySQL allows digit in the beginning of identifier
+ customIdentifierToken: "< IDENTIFIER:
(<LETTER>|<DIGIT>|[\"\\200\"-\"\\377\"])
(<LETTER>|<DIGIT>|<DOLLAR>|[\"\\200\"-\"\\377\"])* >"
Review Comment:
I hope `octal` is emphasized in the comments of the code.
And no other suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
