herunkang2018 commented on code in PR #3211: URL: https://github.com/apache/calcite/pull/3211#discussion_r1201310795
########## core/src/test/resources/sql/functions.iq: ########## @@ -464,4 +464,19 @@ limit 3; !ok +# SUBSTRING +-- returns 'null' +select SUBSTRING(NULL FROM 1 FOR 2); Review Comment: can these test cases in quidem file be put together? I'm not sure if this works for later test cases ########## core/src/test/resources/sql/functions.iq: ########## @@ -464,4 +464,19 @@ limit 3; !ok +# SUBSTRING +-- returns 'null' +select SUBSTRING(NULL FROM 1 FOR 2); Review Comment: can these test cases in quidem file be put together? I'm not sure if this works for later test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
