tanclary commented on PR #3210: URL: https://github.com/apache/calcite/pull/3210#issuecomment-1558709335
> looks good. a few cosmetic changes required. > > did you add tests to big-query.iq? If you can't execute the queries, at least you could validate them using `!type`. > > If you need examples, you should use `emp` and `sal` and `deptno`. It's a lot more meaningful than `unnest(array ...)`. Hey @julianhyde , I amended my commit to include most of your fixes. The only one I couldn't quite do was your suggestion to add tests to big-query.iq. Even just checking the type throws the following error: `Unable to get aggregate implementation for aggregate PERCENTILE_CONT in window context` Of course this makes sense given that there is no aggregate implementation, but if there's a workaround for me to still include these tests please let me know. Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
