DonnyZone commented on PR #3203:
URL: https://github.com/apache/calcite/pull/3203#issuecomment-1560421437
> @DonnyZone thanks for review, but i still not hear any contradictions
against this PR can be merged. If it so - is it possible to merge it ?
Sorry for the late reply. I make some tests in my local environment. The
optimization for `BinaryExpression` seems to be incorrect.
The code after optimization throws compilation error.
```
Boolean a = true || null;
Boolean b = null || true;
```
While the code below works well.
```
Boolean c = true || (Boolean) null;
Boolean d = false || (Boolean) null;
Boolean e = (Boolean) null && true;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
