zoudan commented on code in PR #3224: URL: https://github.com/apache/calcite/pull/3224#discussion_r1205054013
########## core/src/main/java/org/apache/calcite/util/RangeSets.java: ########## @@ -129,7 +129,7 @@ public static <C extends Comparable<C>> int hashCode(RangeSet<C> rangeSet) { public static <C extends Comparable<C>> boolean isPoint(Range<C> range) { return range.hasLowerBound() && range.hasUpperBound() - && range.lowerEndpoint().equals(range.upperEndpoint()) + && range.lowerEndpoint().compareTo(range.upperEndpoint()) == 0 Review Comment: Maybe it is better to add comment for why we use `compareTo` here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org