tanclary commented on code in PR #3214:
URL: https://github.com/apache/calcite/pull/3214#discussion_r1205820685
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -1897,6 +1930,29 @@ public static double atan2(double b0, double b1) {
return Math.atan2(b0, b1);
}
+ // ATANH
+ /** SQL <code>ATANH</code> operator applied to BigDecimal values. */
+ public static double atanh(BigDecimal b) {
+ return atanh(b.doubleValue());
+ }
+
+ /** SQL <code>ATANH</code> operator applied to double values. */
+ public static double atanh(double b) {
Review Comment:
nit: could just check abs(b) <= 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
