liuyongvs commented on code in PR #3231:
URL: https://github.com/apache/calcite/pull/3231#discussion_r1210944460


##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -7909,6 +7909,45 @@ private static void 
checkArrayConcatAggFuncFails(SqlOperatorFixture t) {
         "17357000", "BIGINT NOT NULL");
   }
 

Review Comment:
   only has the definition of function, where is the implementation of the 
function



##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -7909,6 +7909,45 @@ private static void 
checkArrayConcatAggFuncFails(SqlOperatorFixture t) {
         "17357000", "BIGINT NOT NULL");
   }
 
+  @Test void testNamedStruct() {
+    final SqlOperatorFixture f = fixture().withLibrary(SqlLibrary.SPARK);
+    f.setFor(SqlLibraryOperators.NAMED_STRUCT, VmName.EXPAND);
+
+    f.checkFails(

Review Comment:
   need passitive test to test the result



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to