snuyanzin commented on code in PR #3241:
URL: https://github.com/apache/calcite/pull/3241#discussion_r1215607686
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -768,6 +768,19 @@ public static String concat(String s0, String s1) {
return s0 + s1;
}
+ /** Return null only when both s0 and s1 is null,
+ * otherwise null is treated as empty string. */
+ public static String concatWithNull(String s0, String s1) {
Review Comment:
```suggestion
public static @Nullable String concatWithNull(String s0, String s1) {
```
in case it can return `null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
