zoudan commented on code in PR #3230:
URL: https://github.com/apache/calcite/pull/3230#discussion_r1217366700
##########
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##########
@@ -488,7 +488,7 @@ protected RexNode removeCorrelationExpr(
public @Nullable Frame decorrelateRel(Values rel, boolean isCorVarDefined) {
// There are no inputs, so rel does not need to be changed.
- return null;
+ return decorrelateRel((RelNode) rel, isCorVarDefined);
Review Comment:
Perhaps we should improve the commit message and also the title of this PR
because it did not clearly describe the problem
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -7901,4 +7901,22 @@ private void
checkJoinAssociateRuleWithTopAlwaysTrueCondition(boolean allowAlway
.check();
}
+ /**
+ * Test case for
+ * <a
href="https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-5568";>[CALCITE-5568]
+ * The effect of the DecorrelateQuery when there is LogicalValues
Review Comment:
This should be consistent with abstract of the Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
