tanclary commented on code in PR #3238:
URL: https://github.com/apache/calcite/pull/3238#discussion_r1219924761
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -3119,6 +3125,37 @@ private static class ArrayConcatImplementor extends
AbstractRexCallImplementor {
}
}
+ /** Implementor for str_to_map. */
+ private static class StringToMapImplementor extends
AbstractRexCallImplementor {
+ StringToMapImplementor() {
+ super("str_to_map", NullPolicy.STRICT, false);
+ }
+
+ @Override Expression implementSafe(RexToLixTranslator translator,
+ RexCall call, List<Expression> argValueList) {
+ switch (call.getOperands().size()) {
+ case 1:
+ return Expressions.call(
Review Comment:
nit: I'm still wondering if the return can be extracted out of the switch
statement. You notice that in each case it's "return Expressions.call(...)".
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
