julianhyde commented on PR #3248: URL: https://github.com/apache/calcite/pull/3248#issuecomment-1583437350
The commit message is currently as follows: > Correct DATE_TRUNC return type and convert DATEs to TIMESTAMPs for DATETIME_TRUNC and TIMESTAMP_TRUNC for BigQuery That contains 'correct', which is a synonym for 'fix', and is superfluous. Just state the desired behavior. Would the following be better? > BigQuery functions DATETIME_TRUNC and TIMESTAMP_TRUNC should return same type as their first argument, and DATE_TRUNC should return DATE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
