zoudan commented on code in PR #3237:
URL: https://github.com/apache/calcite/pull/3237#discussion_r1226236342


##########
core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java:
##########
@@ -471,6 +471,34 @@ public static SqlOperandTypeChecker variadic(
           .or(OperandTypes.family(SqlTypeFamily.MAP))
           .or(OperandTypes.family(SqlTypeFamily.ANY));
 
+  public static final SqlOperandTypeChecker 
STRING_OR_BINARY_ARRAY_STRING_OPTIONAL_STRING =
+      new FamilyOperandTypeChecker(

Review Comment:
   @liuyongvs, If I understand correctly, what @rubenada meant was we should 
use `SqlTypeFamily.CHARACTER` instead of `SqlTypeFamily.STRING` for the second 
and third parameters. That make sense, I will update it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to