asolimando commented on code in PR #3264:
URL: https://github.com/apache/calcite/pull/3264#discussion_r1229970092
##########
testkit/src/main/java/org/apache/calcite/test/catalog/MockCatalogReaderSimple.java:
##########
@@ -99,6 +108,12 @@ private void registerTableEmpNullables(MockTable
empNullablesTable, Fixture fixt
empNullablesTable.addColumn("COMM", fixture.intTypeNull);
empNullablesTable.addColumn("DEPTNO", fixture.intTypeNull);
empNullablesTable.addColumn("SLACKER", fixture.booleanTypeNull);
+ empNullablesTable.setReferentialConstraints(
+ Lists.newArrayList(
+ RelReferentialConstraintImpl.of(
+ Lists.newArrayList(DEFAULT_CATALOG, DEFAULT_SCHEMA, "EMPNULLABLES"),
+ Lists.newArrayList(DEFAULT_CATALOG, DEFAULT_SCHEMA, "DEPT"),
+ Lists.newArrayList(IntPair.of(7, 0)))));
Review Comment:
Same here, a comment mentioning the column name from both tables would help
clarify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
