JingDas commented on code in PR #3264:
URL: https://github.com/apache/calcite/pull/3264#discussion_r1230725524
##########
testkit/src/main/java/org/apache/calcite/test/catalog/MockCatalogReaderSimple.java:
##########
@@ -468,6 +483,9 @@ private void registerStructTypeTables(Fixture fixture) {
"customBigInt"),
typeFactory -> typeFactory.createSqlType(SqlTypeName.BIGINT));
+ // Register "DEPT" table.
Review Comment:
For this case,
my consideration is that we should need to know the referenced table and the
unique key
before creating the foreign key.
It dosn't cause a exception when we register dept table after emp table in
the test.
Out of habit, I prefer to register the dept table first and then the emp
table.
It also feels OK to keep the previous registration order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
