Aitozi commented on code in PR #3269:
URL: https://github.com/apache/calcite/pull/3269#discussion_r1231891414
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -277,6 +277,13 @@ public class SqlToRelConverter {
private final Map<CorrelationId, DeferredLookup> mapCorrelToDeferred =
new HashMap<>();
+ /**
+ * The scope and identifier to the correlationId to deduplicate the creation
of the
+ * correlationId.
+ */
+ private final Map<Pair<SqlValidatorScope, String>, CorrelationId>
correlationIdMap =
Review Comment:
This map will rely on the object identifier of the scope, in the test case I
posted, It can work well. But I'm not sure whether it's a good enough solution
to reply on this object identifier here.
Looking forward to some suggestion, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
