herunkang2018 commented on code in PR #3267:
URL: https://github.com/apache/calcite/pull/3267#discussion_r1233948488
##########
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##########
@@ -1604,6 +1604,68 @@ private void checkExponentialCnf(int n) {
"true");
}
+ /** Unit test for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-5780";>[CALCITE-5780]
+ * Simplify '1 > x OR 1 <= x OR x IS NULL' to TRUE</a>. */
+ @Test void testSimplifyOrTermsWithReverseOrderComparison() {
+ final RelDataType intType = typeFactory.createSqlType(SqlTypeName.INTEGER);
+ final RelDataType rowType = typeFactory.builder()
+ .add("a", intType).nullable(true)
+ .build();
+
+ final RexDynamicParam range = rexBuilder.makeDynamicParam(rowType, 0);
+ final RexNode aRef = rexBuilder.makeFieldAccess(range, 0);
+
+ // "1 > a or 1 <= a or a is null" ==> "true"
+ checkSimplifyFilter(
+ or(gt(literal(1), aRef),
+ le(literal(1), aRef),
+ isNull(aRef)),
+ "true");
+
+ // "1 <= a or 1 > a or a is null" ==> "true"
+ checkSimplifyFilter(
+ or(le(literal(1), aRef),
+ gt(literal(1), aRef),
+ isNull(aRef)),
+ "true");
+
+ // "a is null or 1 > a or 1 <= a" ==> "true"
+ checkSimplifyFilter(
+ or(isNull(aRef),
+ gt(literal(1), aRef),
+ le(literal(1), aRef)),
+ "true");
+
+ // "2 > a or 0 < a or a is null" ==> "true"
+ checkSimplifyFilter(
+ or(gt(literal(2), aRef),
+ lt(literal(0), aRef),
+ isNull(aRef)),
+ "true");
+
+ // "1 > a or a >= 1 or a is null" ==> "true"
+ checkSimplifyFilter(
+ or(gt(literal(1), aRef),
+ ge(aRef, literal(1)),
+ isNull(aRef)),
+ "true");
+
+ // "1 <= a or a < 1 or a is null" ==> "true"
+ checkSimplifyFilter(
+ or(le(literal(1), aRef),
+ lt(aRef, literal(1)),
+ isNull(aRef)),
+ "true");
+
+ // "a >= 1 or 1 > a or a is null" ==> "true"
Review Comment:
Note that this test case is not effected by this issue, it can be simplified
to true before. I add it just for better code coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
