julianhyde commented on code in PR #3276:
URL: https://github.com/apache/calcite/pull/3276#discussion_r1236016445
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7058,6 +7058,40 @@ private void checkLiteral2(String expression, String
expected) {
.withBigQuery().ok(expected);
}
+ /**
+ * Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-5775";>[CALCITE-5775]</a>;
+ * make sure BigQuery uses {@code NULLS LAST} syntax.
+ */
+ @Test void testBigQueryUsesNullsLastInsteadOfEmulation() {
+ final Function<RelBuilder, RelNode> relFn = b ->
Review Comment:
Could you extend an existing test case, e.g. `testSelectOrderByAscNullsLast`
rather than adding a new one?
Or at least add it next to the existing related test cases. (Adding at the
end causes conflicts.)
Could the input be SQL rather than RelNode?
Follow the conventional format for javadoc comments. 80 char lines, no semi
after `</a>`, include the bug summary inside the `<a>` element.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
