wnob commented on code in PR #3276:
URL: https://github.com/apache/calcite/pull/3276#discussion_r1237795082
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7058,6 +7058,40 @@ private void checkLiteral2(String expression, String
expected) {
.withBigQuery().ok(expected);
}
+ /**
+ * Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-5775";>[CALCITE-5775]</a>;
+ * make sure BigQuery uses {@code NULLS LAST} syntax.
+ */
+ @Test void testBigQueryUsesNullsLastInsteadOfEmulation() {
+ final Function<RelBuilder, RelNode> relFn = b ->
Review Comment:
I'm thinking now that the 2 existing tests that were affected by this change
are enough. They test a `NULLS LAST` and a `DESC NULLS FIRST`. This new test
will be for CALCITE-5775 as opposed to CALCITE-5793.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
